interfaces: clean system apparmor cache on core device (2.29) #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system apparmor cache relies on the mtime of the input files and will only check for the newest mtime. However this is problematic on rollbacks when we rollback to a core the mtime of the apparmor files in the rollback core will be older so that apparmor cache does not get updated. This means that on rollback of core we run e.g. snap-confine with the appamor profile of the core we just reverted from. Ideally this would be fixed in apparmor itself, however as a short term fix we can simply clean the cache (it usually contains just sbin.dhclient and snap-confine anyway) and let apparmor rebuild the cache dynamically. See also https://forum.snapcraft.io/t/core-snap-revert-issues-on-core-devices
Codecov Report
@@ Coverage Diff @@
## release/2.29 #4084 +/- ##
===============================================
Coverage ? 75.79%
===============================================
Files ? 433
Lines ? 37187
Branches ? 0
===============================================
Hits ? 28185
Misses ? 7029
Partials ? 1973
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #4060 to 2.29.