cmd/snap-update-ns: fix mount rules for font sharing #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mount rules should refer to directories, not files (the traling slash is relevant). Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
zyga
force-pushed
the
fix/font-sharing
branch
from
5ad5cb1
to
e39528a
Compare
jdstrand
approved these changes
Nov 2, 2017
| echo "The plug is connected by default" | ||
| snap interfaces | MATCH "$CONNECTED_PATTERN" | ||
|
|
||
| echo "Then the snap is able to desktop files and directories" |
There was a problem hiding this comment.
This is coming from a patch by @sergiocazzolato
Codecov Report
@@ Coverage Diff @@
## master #4136 +/- ##
==========================================
+ Coverage 75.62% 75.63% +0.01%
==========================================
Files 435 435
Lines 37583 37613 +30
==========================================
+ Hits 28421 28450 +29
+ Misses 7173 7170 -3
- Partials 1989 1993 +4
Continue to review full report at Codecov.
|
Merged
This patch fixes a nasty bug that results in wrong list of made changes. This is caused by how the for / range syntax operates in golang. Before this patch the list of changes made contains N copies of the first change. This seems to be caused by golang using a hidden temporary variable that gets overwritten but has the same address. We add the address of that variable to the list of changes. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
mvo5
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mount rules should refer to directories, not files (the traling
slash is relevant).
Signed-off-by: Zygmunt Krynicki me@zygoon.pl