Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/time*_control: explicitly deny noisy read on /proc/1/environ #4216

Merged

Conversation

jdstrand
Copy link

systemd utilities look at /proc/1/environ to see if running in a container, but
they will fallback gracefully. No other interfaces allow this denial, so no
problems with silencing it for now. Note that allowing this triggers a 'ptrace
trace peer=unconfined' denial, which we want to avoid.

Reference:
https://forum.snapcraft.io/t/managing-time-date-and-timezone-in-ubuntu-core/408/44

systemd utilities look at /proc/1/environ to see if running in a container, but
they will fallback gracefully. No other interfaces allow this denial, so no
problems with silencing it for now. Note that allowing this triggers a 'ptrace
trace peer=unconfined' denial, which we want to avoid.

Reference:
https://forum.snapcraft.io/t/managing-time-date-and-timezone-in-ubuntu-core/408/44
Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

codecov-io commented Nov 15, 2017

Codecov Report

Merging #4216 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4216      +/-   ##
=========================================
+ Coverage   75.86%   76.1%   +0.23%     
=========================================
  Files         439     440       +1     
  Lines       38232   38532     +300     
=========================================
+ Hits        29004   29323     +319     
+ Misses       7216    7179      -37     
- Partials     2012    2030      +18
Impacted Files Coverage Δ
interfaces/builtin/time_control.go 100% <ø> (ø) ⬆️
interfaces/builtin/timeserver_control.go 100% <ø> (ø) ⬆️
interfaces/builtin/timezone_control.go 100% <ø> (ø) ⬆️
interfaces/builtin/browser_support.go 76.08% <0%> (-0.23%) ⬇️
interfaces/builtin/opengl.go 100% <0%> (ø) ⬆️
overlord/snapstate/readme.go 75% <0%> (ø)
overlord/snapstate/snapmgr.go 87.83% <0%> (+3.82%) ⬆️
store/store.go 83.89% <0%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba27d6a...c386a69. Read the comment docs.

@zyga zyga merged commit 1e6e9ee into snapcore:master Nov 15, 2017
@jdstrand jdstrand deleted the add-explicit-deny-rule-for-timedatctl branch November 21, 2017 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants