snap: introduce timer service data types and validation #4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboozzoo
changed the title
bboozzoo
changed the title
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Introduce basic data types and validation for timer services.
Timer service is defined in snap.yaml as follows:
..
apps:
foo:
command: bin/foo
daemon: oneshot # one of simple|forking|oneshot|dbus|notify
timer: mon,10:00-12:00 # valid timer specification
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/service-timers-basics
branch
from
4ee83ab
to
24a964f
Compare
zyga
approved these changes
Feb 7, 2018
| @@ -549,11 +558,16 @@ type HookInfo struct { | |||
| Slots map[string]*SlotInfo | |||
| } | |||
|
|
|||
| // File returns the path to the file | |||
| // File returns the path to the *.socket file | |||
| func (socket *SocketInfo) File() string { | |||
| return filepath.Join(dirs.SnapServicesDir, socket.App.SecurityTag()+"."+socket.Name+".socket") | |||
There was a problem hiding this comment.
Nitpick for later, use fmt.Sprintf here. No need to do it now.
| func (socket *SocketInfo) File() string { | ||
| return filepath.Join(dirs.SnapServicesDir, socket.App.SecurityTag()+"."+socket.Name+".socket") | ||
| } | ||
|
|
||
| // File returns the path to the *.timer file | ||
| func (timer *TimerInfo) File() string { | ||
| return filepath.Join(dirs.SnapServicesDir, timer.App.SecurityTag()+".timer") |
Codecov Report
@@ Coverage Diff @@
## master #4633 +/- ##
=========================================
+ Coverage 78.29% 78.3% +0.01%
=========================================
Files 464 464
Lines 32939 32955 +16
=========================================
+ Hits 25789 25807 +18
+ Misses 5019 5018 -1
+ Partials 2131 2130 -1
Continue to review full report at Codecov.
|
mvo5
approved these changes
Feb 13, 2018
| apps: | ||
| foo: | ||
| daemon: oneshot | ||
| timer: mon,10:00-12:00,mon2-wed3 |
There was a problem hiding this comment.
Curious what will happen with timer: is empty. I assume a parser failure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce basic data types and validation for timer services.
Timer service is defined in snap.yaml as follows: