Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/screen-inhibit-control,network-status: fix dbus path and interface typos #4733

Merged
merged 2 commits into from Feb 26, 2018

Conversation

jdstrand
Copy link

@jdstrand jdstrand commented Feb 23, 2018

Fix typo in path component in DBus rule for screen-inhibit-control where it had a '.' instead of a '/'. Verified no other interfaces have the same bug. Also fix typo in network-status in interface component in DBus rule where it had a /** instead of *. (Note, ** is only useful for 'path', * is equivalent to ** with interface). Verified no other interfaces have this bug.

Reference:

Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -67,7 +67,7 @@ dbus (send)
# API rule
dbus (send)
bus=session
path=/{,org/freedesktop/,org.gnome/}ScreenSaver
path=/{,org/freedesktop/,org/gnome/}ScreenSaver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@codecov-io
Copy link

Codecov Report

Merging #4733 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4733      +/-   ##
==========================================
+ Coverage   78.64%   78.86%   +0.21%     
==========================================
  Files         468      468              
  Lines       33739    34057     +318     
==========================================
+ Hits        26535    26859     +324     
+ Misses       5046     5045       -1     
+ Partials     2158     2153       -5
Impacted Files Coverage Δ
interfaces/builtin/screen_inhibit_control.go 100% <ø> (ø) ⬆️
interfaces/builtin/network_status.go 76.92% <ø> (ø) ⬆️
store/auth.go 87.58% <0%> (+0.16%) ⬆️
overlord/hookstate/hookmgr.go 73.14% <0%> (+1.14%) ⬆️
store/store.go 85.98% <0%> (+4.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e218f43...1bb9e40. Read the comment docs.

@mvo5 mvo5 merged commit 3b1cbdd into snapcore:master Feb 26, 2018
@jdstrand
Copy link
Author

Thanks for the merge!

@jdstrand jdstrand deleted the fix-dbus-path-and-interface-typos branch May 17, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants