wrappers, tests/main/snap-service-timer: restore missing commit, add spread test for timer services #4758
Conversation
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
|
Somehow this commit did not end up being merged bboozzoo@ccb91b2 Will push an update shortly. |
bboozzoo
changed the title
… shipped in ubuntu-14.04 Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
| regular-timer: | ||
| command: bin/loop regular-timer | ||
| daemon: simple | ||
| timer: 0:00-24:00/96 |
There was a problem hiding this comment.
To help casual reviewers. Is it correct to say that this means # Run every 15 minutes.?
| random-timer: | ||
| command: bin/loop random-timer | ||
| daemon: simple | ||
| timer: 0:00~24:00/96 |
There was a problem hiding this comment.
This one is # Run roughly every 15 minutes, with (some) random distribution.
| @@ -560,8 +560,7 @@ X-Snappy=yes | |||
| [Timer] | |||
| Unit={{.ServiceFileName}} | |||
| {{ range .Schedules }}OnCalendar={{ . }} | |||
| {{- end }} | |||
There was a problem hiding this comment.
Does this mean we used to generate a broken service file that needs to be updated?
There was a problem hiding this comment.
The piece of code that did this got merged just today. On top of this, the snap won't install as systemd will reject the timer file we produced.
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
…tten Increase compatibility with older systemd and make sure to do a daemon-reload wheneven a new service file was written. Newer versions of systemd reload automatically and print out a warning about on-disk service files being changed. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #4758 +/- ##
==========================================
+ Coverage 78.74% 78.76% +0.01%
==========================================
Files 468 468
Lines 33897 33901 +4
==========================================
+ Hits 26693 26701 +8
+ Misses 5041 5039 -2
+ Partials 2163 2161 -2
Continue to review full report at Codecov.
|
A spread test for timer services.