many: delay classic registration until first store interaction #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4873 +/- ##
==========================================
+ Coverage 79.11% 79.13% +0.02%
==========================================
Files 478 478
Lines 35491 35606 +115
==========================================
+ Hits 28079 28178 +99
- Misses 5192 5199 +7
- Partials 2220 2229 +9
Continue to review full report at Codecov.
|
bboozzoo
reviewed
Mar 28, 2018
overlord/devicestate/devicemgr.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // waitForRegistrationTimeout is the timeout after which waitForRegistration will give up, about the same as network retries max timeout |
There was a problem hiding this comment.
Can you wrap the comment?
overlord/devicestate/devicemgr.go
Outdated
| // on classic the first time around we just do | ||
| // prepare-device + key gen and then pause the process | ||
| // until the first store interaction | ||
| full = err != state.ErrNoState |
There was a problem hiding this comment.
nitpick, but I find this easier to read when scanning though the code:
if err == state.ErrNoState {
full = false
}
pedronis
added
⛔ Blocked
and removed
⚠ Critical
pedronis
force-pushed
the
delay-classic-registration
branch
from
ee1b28e
to
59a7d5b
Compare
…via devicestate for a serial, tweak comments
…ensuring we are registered
…state auto-refresh logic based on whether we are registered or not or we should proceed anyway
pedronis
force-pushed
the
delay-classic-registration
branch
from
9191d59
to
c66d35c
Compare
bboozzoo
reviewed
May 14, 2018
| @@ -105,6 +130,19 @@ func (m *DeviceManager) markRegistered() { | |||
| close(m.reg) | |||
| } | |||
|
|
|||
| func (m *DeviceManager) markRegistrationFirstAttempt() { | |||
| if m.registrationFirstAttempted { | |||
There was a problem hiding this comment.
Shouldn't this be covered by a mutex or use atomic compare and swap?
There was a problem hiding this comment.
it's always called with the state lock taken, otoh this PR is super likely to get closed soon
|
closing this as discussed with Bret |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XXX UPDATE:
fakestore as well (but it's a larger change because it doesn't support the session endpoints yet and
could be done in a follow up)