tests: fix flaky test for hooks undo #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects created in test setup.
stolowski
added
⚠ Critical
zyga
approved these changes
Jun 5, 2018
Codecov Report
@@ Coverage Diff @@
## master #5268 +/- ##
==========================================
- Coverage 78.85% 78.84% -0.02%
==========================================
Files 498 498
Lines 37488 37488
==========================================
- Hits 29562 29557 -5
- Misses 5528 5531 +3
- Partials 2398 2400 +2
Continue to review full report at Codecov.
|
chipaca
approved these changes
Jun 6, 2018
|
I took the simple out as it was short but definitely required some insight into what is going on in the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix improper (and unintended) use of task/change variables initialized in test setup. With this PR the undo test creates own task/change variables, local to the test. The problem is that TestSetup creates a configure task and adds it to s.change, the tasks in the undo test itself don't wait for it so the order of execution is random with regard to configure, and this occasionally yelds unexpected status of entire change and the hook task in question when everything is undone.