cmd/snap-update-ns: improve wording in many errors #5272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many error messages were of the form "cannot create path /full/path: cannot do stuff to segment "path": real reason for the error". Those got simplified to just "cannot do stuff to /path/that/failed: real reason for the error". Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
The target (aka oldname) cannot be empty so we should just check it internally in the place that creates those symlinks. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Attempting to open an unclean paths now provide a more complete and correct error message than before. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #5272 +/- ##
=========================================
Coverage ? 78.84%
=========================================
Files ? 500
Lines ? 37477
Branches ? 0
=========================================
Hits ? 29548
Misses ? 5529
Partials ? 2400
Continue to review full report at Codecov.
|
stolowski
approved these changes
Jun 7, 2018
| @@ -116,9 +111,6 @@ func (c *Change) createPath(path string, pokeHoles bool, sec *Secure) ([]*Change | |||
| // performed the hole poking and thus additional changes must be nil. | |||
| _, err = c.createPath(path, false, sec) | |||
| } | |||
| } else if err != nil { | |||
There was a problem hiding this comment.
That's probably ok and means we will not decorate the error with extra message and just return it as is; is this intended?
There was a problem hiding this comment.
Yes, as a part of this change the errors produced by things called by createPath internally now return appropriate error messages by themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains assorted tweaks for how error handling in snap-update-ns looks like.
I will have more similar patches as I work towards the validation solution but I think this is
okay to propose already.