Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces: add Repository.AllInterfaces #5325

Merged
merged 1 commit into from Jun 15, 2018

Conversation

zyga
Copy link
Collaborator

@zyga zyga commented Jun 14, 2018

This patch adds a helper method that returns all the interfaces that
were added to a repository. It will be used by upcoming refactoring of
implicit interfaces.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

This patch adds a helper method that returns all the interfaces that
were added to a repository. It will be used by upcoming refactoring of
implicit interfaces.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
@zyga zyga added the Simple 😃 A small PR which can be reviewed quickly label Jun 14, 2018
Copy link
Contributor

@stolowski stolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

Codecov Report

Merging #5325 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5325      +/-   ##
==========================================
+ Coverage   78.94%   78.95%   +<.01%     
==========================================
  Files         503      503              
  Lines       37712    37720       +8     
==========================================
+ Hits        29771    29781      +10     
+ Misses       5531     5530       -1     
+ Partials     2410     2409       -1
Impacted Files Coverage Δ
interfaces/repo.go 95.86% <100%> (+0.06%) ⬆️
overlord/hookstate/hookmgr.go 75.24% <0%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ecc3af...9a41b0d. Read the comment docs.

@stolowski stolowski merged commit 000181d into snapcore:master Jun 15, 2018
@zyga zyga deleted the tweak/all-interfaces branch June 21, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
4 participants