tests: show status of the partial test-snapd-huge snap in econnreset test #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiocazzolato
approved these changes
Jun 15, 2018
stolowski
approved these changes
Jun 15, 2018
store/store.go
Outdated
| @@ -1391,6 +1397,7 @@ func (s *Store) Download(ctx context.Context, name string, targetPath string, do | |||
| // If hashsum is incorrect retry once | |||
| if _, ok := err.(HashError); ok { | |||
| logger.Debugf("Hashsum error on download: %v", err.Error()) | |||
| logger.Debugf("Truncating an trying again from scratch.") | |||
There was a problem hiding this comment.
tryin' an' tryin' an' tryin'
| echo "Partial download status" | ||
| ls -lh test-snapd-huge_* || true | ||
| echo "other dir content" | ||
| ls -lh |
There was a problem hiding this comment.
Would it make sense to dump /var/lib/snapd/cache here and reset it before the test?
There was a problem hiding this comment.
I mean, maybe? But snap download does not use that directory.
chipaca
force-pushed
the
econn-reset-debug
branch
from
07b9183
to
0c2cd7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5333 +/- ##
==========================================
+ Coverage 78.98% 78.98% +<.01%
==========================================
Files 503 503
Lines 37749 37757 +8
==========================================
+ Hits 29815 29822 +7
- Misses 5528 5529 +1
Partials 2406 2406
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if we simply have the problem that the download is so fast that the iptables block is too late and the file is already fully downloaded.