asserts: add (optional) kernel-track to model assertion #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows specifying the kernel track in the model assertion so that e.g. core18 can pull in a 4.15 kernel when building a core18 system. If this gets accepted we need to add code to `snap prepare-image` to pull the kernel from the right track and also code to snapstate to ensure the track of the kernel cannot be changed. This is also discussed in https://forum.snapcraft.io/t/5947
Codecov Report
@@ Coverage Diff @@
## master #5401 +/- ##
==========================================
- Coverage 79% 78.97% -0.04%
==========================================
Files 503 512 +9
Lines 37981 38756 +775
==========================================
+ Hits 30007 30607 +600
- Misses 5549 5692 +143
- Partials 2425 2457 +32
Continue to review full report at Codecov.
|
pedronis
requested changes
Jul 10, 2018
| @@ -81,6 +81,11 @@ func (mod *Model) Kernel() string { | |||
| return mod.HeaderString("kernel") | |||
| } | |||
|
|
|||
| // KernelTrack returns the kernel track the model uses. | |||
There was a problem hiding this comment.
I think we want also a call to checkOptionalString(assert.headers, "kernel-track") in assembleModel
There was a problem hiding this comment.
@pedronis fixed and pushed, please have a look
This ensures that kernel-track is, if present, a string and that it is not defined for classic models. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
mvo5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifying the kernel track in the model assertion
so that e.g. core18 can pull in a 4.15 kernel when building a
core18 system.
If this gets accepted we need to add code to
snap prepare-imageto pull the kernel from the right track and also code to snapstate
to ensure the track of the kernel cannot be changed.
If it gets accepted we can also create official core18 model assertions
which means the code in #5398
can be reverted :)
This is also discussed in https://forum.snapcraft.io/t/5947