store, daemon, client, cmd/snap: expose "scope", default to wide #5479
Conversation
This adds support for the store's new `scope` query parameter, exposed directly to clients, and defaults the `snap find` to use `scope=wide` (i.e. get results for any architecture and branch unless it's `devmode`). Use `snap find --narrow <query>` to get back the old behaviour.
|
|
||
| s.rsnaps = []*snap.Info{} | ||
|
|
||
| req, err := http.NewRequest("GET", "/v2/find?q=foo&scope=creep", nil) |
| @@ -127,6 +127,7 @@ type FindOptions struct { | |||
| Prefix bool | |||
| Query string | |||
| Section string | |||
| Scope string | |||
There was a problem hiding this comment.
What can effectively be passed as scope here aside from wide?
cmd/snap/cmd_find.go
Outdated
| @@ -160,6 +161,7 @@ func init() { | |||
| return &cmdFind{} | |||
| }, map[string]string{ | |||
| "private": i18n.G("Search private snaps"), | |||
| "narrow": i18n.G("Only search for snaps in 'stable' and for the current architecture"), | |||
There was a problem hiding this comment.
are we sure wide find other archs, it doesn't seem to be the case. I expect some potential bikeshedding on the name of this option
There was a problem hiding this comment.
I'm sure we don't, now. I'll fix.
| @@ -622,6 +622,7 @@ func searchStore(c *Command, r *http.Request, user *auth.UserState) Response { | |||
| q := query.Get("q") | |||
| section := query.Get("section") | |||
| name := query.Get("name") | |||
| scope := query.Get("scope") | |||
There was a problem hiding this comment.
should we check whether scope is only "wide" or empty ?
There was a problem hiding this comment.
or from another POV, do we get a sane enough error if it's set to something else?
There was a problem hiding this comment.
I see no harm in passing it through, as long as it's not exposed to the end-user directly
There was a problem hiding this comment.
we get no error if it's set to something weird
This adds support for the store's new
scopequery parameter, exposeddirectly to clients, and defaults the
snap findto usescope=wide(i.e. get results for any architecture and branch unless it's
devmode).Use
snap find --narrow <query>to get back the old behaviour.