interfaces: tweak tests of daemon-notify, use common naming #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch applies the following standardization to unit tests: - specification objects are named `spec` when tested alone - snap hosting the plug is called `consumer` and has one app `app` - snap hosting the slot is called `provider` Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #5500 +/- ##
==========================================
- Coverage 78.96% 78.95% -0.01%
==========================================
Files 512 512
Lines 38734 38734
==========================================
- Hits 30586 30584 -2
- Misses 5692 5693 +1
- Partials 2456 2457 +1
Continue to review full report at Codecov.
|
jdstrand
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch applies the following standardization to unit tests:
specwhen tested aloneconsumerand has one appappproviderSigned-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com