Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix tests expecting old email address #5535

Merged
merged 3 commits into from Jul 19, 2018

Conversation

zyga
Copy link
Collaborator

@zyga zyga commented Jul 18, 2018

The store was re-indexed and the contact field on canonical snaps has
changed. This updates the tests to match

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

The store was re-indexed and the contact field on canonical snaps has
changed. This updates the tests to match

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
@zyga zyga added Simple 😃 A small PR which can be reviewed quickly ⚠ Critical High-priority stuff (e.g. to fix master) labels Jul 18, 2018
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, @mvo do we need this for 2.34.1 for SRU ?

Copy link
Collaborator

@sergiocazzolato sergiocazzolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other snapd such as test-snapd-tools also changed the contact

@sergiocazzolato
Copy link
Collaborator

@zyga I have pushed a change to make the snap-info test work again.

@zyga
Copy link
Collaborator Author

zyga commented Jul 18, 2018

Woot, thank you very much @sergiocazzolato

@mvo5
Copy link
Contributor

mvo5 commented Jul 19, 2018

Heh, #5534 fixes this as well.

@stolowski stolowski merged commit 342b234 into snapcore:master Jul 19, 2018
@chipaca
Copy link
Contributor

chipaca commented Jul 19, 2018

What's the reason for the unknown|unset change? It seems wrong and backwards, a priori.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Critical High-priority stuff (e.g. to fix master) Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
6 participants