(2.34) cmd/snap-confine: allow ptrace read for 4.18 kernels #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kernels < 4.18 incorrectly require 'ptrace trace' to read /proc/1/ns/mnt and this was correctly to only require 'ptrace read'. This commit simply adds 'ptrace read peer=unconfined,', leaving the old 'trace' rule. A future commit will remove the 'trace' rule by default and interrogate the kernel to conditionally add it back when needed. Reference: https://forum.snapcraft.io/t/custom-kernel-error-on-readlinkat-in-mount-namespace/6097/19
|
@mvo5 - this isn't super urgent for 2.34, but it would be nice to have sooner than later. |
bboozzoo
approved these changes
Jul 31, 2018
bboozzoo
changed the title
|
FYI, the test failures are unrelated -- gce failures on arch. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernels < 4.18 incorrectly require 'ptrace trace' to read /proc/1/ns/mnt and
this was corrected to only require 'ptrace read'. This commit simply adds
'ptrace read peer=unconfined,', leaving the old 'trace' rule. A future commit
will remove the 'trace' rule by default and interrogate the kernel to
conditionally add it back when needed.
Reference:
https://forum.snapcraft.io/t/custom-kernel-error-on-readlinkat-in-mount-namespace/6097/19