Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlord/devicestate: deny parallel install of kernel or gadget snaps #5587

Conversation

bboozzoo
Copy link
Collaborator

@bboozzoo bboozzoo commented Aug 1, 2018

Deny parallel installation of kernel or gadget snaps.

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
@bboozzoo bboozzoo added Simple 😃 A small PR which can be reviewed quickly Parallel installs labels Aug 1, 2018
@codecov-io
Copy link

Codecov Report

Merging #5587 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5587      +/-   ##
=========================================
+ Coverage   79.09%   79.1%   +<.01%     
=========================================
  Files         515     515              
  Lines       39172   39174       +2     
=========================================
+ Hits        30983   30987       +4     
+ Misses       5691    5690       -1     
+ Partials     2498    2497       -1
Impacted Files Coverage Δ
overlord/devicestate/devicestate.go 78.57% <100%> (+0.31%) ⬆️
overlord/hookstate/hookmgr.go 74.51% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61edcca...d46c2db. Read the comment docs.

@chipaca
Copy link
Contributor

chipaca commented Aug 1, 2018

so, we expect people to do parallel installs of core snaps?

Copy link
Contributor

@chipaca chipaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does what it says on the box.

But, it does make me wonder about core snaps.

@bboozzoo
Copy link
Collaborator Author

bboozzoo commented Aug 1, 2018

There's some TODO notes regarding core and snapd snaps left here still https://github.com/snapcore/snapd/blob/master/overlord/snapstate/snapstate.go#L90

@bboozzoo bboozzoo merged commit 0895287 into snapcore:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
4 participants