wrappers: do not glob when removing desktop files #5599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use 'snap_*.desktop' globbing when removing desktop files. This would accidentally remove desktop files of other snap instances of the same snap. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
bboozzoo
added
Simple 😃
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
mvo5
approved these changes
Aug 6, 2018
Codecov Report
@@ Coverage Diff @@
## master #5599 +/- ##
==========================================
+ Coverage 78.94% 78.94% +<.01%
==========================================
Files 518 518
Lines 39439 39441 +2
==========================================
+ Hits 31134 31136 +2
- Misses 5773 5774 +1
+ Partials 2532 2531 -1
Continue to review full report at Codecov.
|
chipaca
approved these changes
Aug 6, 2018
wrappers/desktop.go
Outdated
| return err | ||
| } | ||
| } else { | ||
| activeDesktopFiles = append(activeDesktopFiles, app.DesktopFile()) |
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use
snap_*.desktopglobbing when removing desktop files. This wouldaccidentally remove desktop files of other snap instances of the same snap.