Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add dbus monitor log to interfaces-accounts-service #5602

Merged
merged 1 commit into from Aug 6, 2018

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Aug 6, 2018

We saw some failures in the tests:

Creating account
+ gdbus call --session --timeout 300 --dest=org.gnome.OnlineAccounts --object-path=/org/gnome/OnlineAccounts/Manager --method=org.gnome.OnlineAccounts.Manager.AddAccount imap_smtp test@example.com 'Display Name' '{}' '{'\''Enabled'\'': '\''true'\'', '\''EmailAddress'\'': '\''test@example.com'\'', '\''Name'\'': '\''Test User'\'', '\''ImapHost'\'': '\''imap.example.com'\'', '\''SmtpHost'\'': '\''mail.example.com'\''}'
Error: GDBus.Error:org.freedesktop.DBus.Error.InvalidArgs: Type of message, '(ssssa{ss})', does not match expected type '(sssa{sv}a{ss})'

and it would be nice to get to the bottom of this.

We saw some failures in the tests:
```
Creating account
+ gdbus call --session --timeout 300 --dest=org.gnome.OnlineAccounts --object-path=/org/gnome/OnlineAccounts/Manager --method=org.gnome.OnlineAccounts.Manager.AddAccount imap_smtp test@example.com 'Display Name' '{}' '{'\''Enabled'\'': '\''true'\'', '\''EmailAddress'\'': '\''test@example.com'\'', '\''Name'\'': '\''Test User'\'', '\''ImapHost'\'': '\''imap.example.com'\'', '\''SmtpHost'\'': '\''mail.example.com'\''}'
Error: GDBus.Error:org.freedesktop.DBus.Error.InvalidArgs: Type of message, '(ssssa{ss})', does not match expected type '(sssa{sv}a{ss})'
```
and it would be nice to get to the bottom of this.
@codecov-io
Copy link

Codecov Report

Merging #5602 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5602      +/-   ##
==========================================
+ Coverage   78.94%   78.94%   +<.01%     
==========================================
  Files         518      518              
  Lines       39439    39439              
==========================================
+ Hits        31134    31136       +2     
+ Misses       5773     5772       -1     
+ Partials     2532     2531       -1
Impacted Files Coverage Δ
overlord/hookstate/hookmgr.go 74.51% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0f7d5...664ced6. Read the comment docs.

@mvo5 mvo5 merged commit 777379b into snapcore:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants