Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/lib/prepare: fix extra snaps test #5625

Merged
merged 1 commit into from Aug 10, 2018
Merged

tests/lib/prepare: fix extra snaps test #5625

merged 1 commit into from Aug 10, 2018

Conversation

bboozzoo
Copy link
Collaborator

Fix a silly bug.

@bboozzoo
tests/lib/prepare: fix extra snaps test
bdb9700 
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
@bboozzoo bboozzoo added the Simple 😃 A small PR which can be reviewed quickly label Aug 10, 2018
@zyga zyga added the ⚠ Critical High-priority stuff (e.g. to fix master) label Aug 10, 2018
mvo5
mvo5 approved these changes Aug 10, 2018
View reviewed changes
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah!

@codecov-io
Copy link

Codecov Report

Merging #5625 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5625      +/-   ##
==========================================
+ Coverage   78.94%   78.94%   +<.01%     
==========================================
  Files         520      520              
  Lines       39568    39571       +3     
==========================================
+ Hits        31235    31238       +3     
- Misses       5789     5790       +1     
+ Partials     2544     2543       -1
Impacted Files Coverage Δ
overlord/ifacestate/handlers.go 64.88% <0%> (-0.4%) ⬇️
overlord/snapstate/snapstate.go 81.29% <0%> (+0.05%) ⬆️
overlord/hookstate/hookmgr.go 74.51% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4375ae0...bdb9700. Read the comment docs.

@bboozzoo bboozzoo merged commit ebc2a08 into snapcore:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyga zyga zyga approved these changes

@mvo5 mvo5 mvo5 approved these changes

Assignees
No one assigned
Labels
⚠ Critical High-priority stuff (e.g. to fix master) Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Milestone
No milestone
4 participants
@bboozzoo @codecov-io @zyga @mvo5