Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/snap: fix some corner-case test setup weirdness #5627

Merged
merged 2 commits into from Aug 10, 2018
Merged

cmd/snap: fix some corner-case test setup weirdness #5627

merged 2 commits into from Aug 10, 2018

Commits on Aug 10, 2018

  1. cmd/snap: fix some corner-case test setup weirdness 

    In some cases, when running the tests in a particular way, some bits
of the environment were not set up properly and tests would fail. In
particular colour support was getting isatty for stdout wrong, as it
was never mocked outside of the colour tests. And dbus tests were
failing to unset the session bus env var. It's a mystery how these
things sometimes worked :-) but this should fix it for good.

I've also taken the opportunity to unify our isatty handling (at least
within cmd/snap; there's still code in progress/ doing it separately).
    @chipaca
    chipaca committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    fb730e1 View commit details
    Browse the repository at this point in the history

  2. testutil: wait for dbustest's dbus-daemon to start

    @chipaca
    chipaca committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    09040a2 View commit details
    Browse the repository at this point in the history