tests: new test for udisks2 interface #5645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
approved these changes
Aug 14, 2018
|
|
||
| echo "Check we can mount/unmount a block device using the snap" | ||
| # create a 10M filesystem in /opt | ||
| dd if=/dev/zero of=/opt/dev0-fake0 bs=1M count=10 |
There was a problem hiding this comment.
Agree with @mvo5 /opt seems odd here, could you use PWD instead?
bboozzoo
reviewed
Aug 14, 2018
| snap disconnect test-snapd-udisks2:udisks2 | ||
|
|
||
| echo "Then the snap is not able to check udisks2 status" | ||
| if test-snapd-udisks2.udisksctl status 2>${PWD}/call.error; then |
There was a problem hiding this comment.
"${PWD}" or just if test-snapd-udisks2.udisksctl status 2> call.error; then ..
|
|
||
| echo "Check we can mount/unmount a block device using the snap" | ||
| # create a 10M filesystem in /opt | ||
| dd if=/dev/zero of=/opt/dev0-fake0 bs=1M count=10 |
There was a problem hiding this comment.
Agree with @mvo5 /opt seems odd here, could you use PWD instead?
udisks2 daemon is needed to make udisks2 snap work.
Codecov Report
@@ Coverage Diff @@
## master #5645 +/- ##
==========================================
- Coverage 78.93% 78.92% -0.02%
==========================================
Files 520 520
Lines 39613 39623 +10
==========================================
+ Hits 31270 31271 +1
- Misses 5797 5807 +10
+ Partials 2546 2545 -1
Continue to review full report at Codecov.
|
bboozzoo
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.