Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: avoid using the journalctl cursor when it has not been created yet #5662

Merged

Conversation

sergiocazzolato
Copy link
Collaborator

@sergiocazzolato sergiocazzolato commented Aug 15, 2018

This is for the scenario when the cursor was not calculated and the test
suite fails on the first test during the preparation.

This is the error we want to fix:
https://paste.ubuntu.com/p/RJH7cZXSwT/

This is for the scenario when the cursor was not calculated and the test
suite fails on the first test during the preparation.
Copy link
Contributor

@chipaca chipaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6867c62). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5662   +/-   ##
=========================================
  Coverage          ?   78.95%           
=========================================
  Files             ?      521           
  Lines             ?    39682           
  Branches          ?        0           
=========================================
  Hits              ?    31331           
  Misses            ?     5805           
  Partials          ?     2546

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6867c62...c2700be. Read the comment docs.

@bboozzoo bboozzoo merged commit de5c7ba into snapcore:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants