tests: fix autopkgtest failures in cosmic #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent autopkgtest run in cosmic had some issues that are fixed here.
Codecov Report
@@ Coverage Diff @@
## master #5666 +/- ##
=======================================
Coverage 78.96% 78.96%
=======================================
Files 522 522
Lines 39711 39711
=======================================
Hits 31358 31358
Misses 5807 5807
Partials 2546 2546Continue to review full report at Codecov.
|
zyga
approved these changes
Aug 16, 2018
| @@ -55,6 +55,10 @@ ensure_file_exists_backup_real() { | |||
| if [ -f "$file" ]; then | |||
| mv "$file" "$file.back" | |||
| fi | |||
| # ensure the parent dir is available | |||
| if [ ! -d "$(dirname $file)" ]; then | |||
| mkdir -p "$(dirname $file)" | |||
There was a problem hiding this comment.
We could just call mkdir -p ... since that's exactly what it means anyway. Not a blocker, just calling it out.
| # profile="snap.test-snapd-eds.calendar" pid=19219 comm="calendar" | ||
| # family="unix" sock_type="stream" protocol=0 requested_mask="send | ||
| # receive connect" denied_mask="send connect" addr=none | ||
| # peer_addr="@/tmp/dbus-5FUilMiW8U" peer="unconfined" |
There was a problem hiding this comment.
This looks like a bug. I'll add a card for that to my queue.
sergiocazzolato
approved these changes
Aug 16, 2018
|
Some conflicts in this branch. |
stolowski
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent autopkgtest run in cosmic had some issues that are
fixed here.