strutil: fix MatchCounter to also work with buffer reuse #5744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`strutil.MatchCounter` had a bug where, if the caller reused the `[]byte` in later calls, the contents of a (supposedly) internal buffer got overwritten. This fixes that by switching to copying it to a bytes.Buffer. We could also instead do the accounting ourselves but that seems like too much fiddly work.
bboozzoo
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strutil.MatchCounterhad a bug where, if the caller reused the[]byteinlater calls, the contents of a (supposedly) internal buffer got overwritten.
This fixes that by switching to copying it to a bytes.Buffer. We could also
instead do the accounting ourselves but that seems like too much fiddly work.