Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging/fedora: Merge changes from Fedora Dist-Git #5750

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Conan-Kudo
Copy link
Contributor

Fedora Dist-Git carries changes that should be merged back into the snapd reference packaging files.

Signed-off-by: Neal Gompa ngompa13@gmail.com

Fedora Dist-Git carries changes that should be merged back into
the snapd reference packaging files.

Signed-off-by: Neal Gompa <ngompa13@gmail.com>
Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@@ -662,9 +682,8 @@ popd
%{_sysconfdir}/profile.d/snapd.sh
%{_unitdir}/snapd.socket
%{_unitdir}/snapd.service
%{_unitdir}/snapd.seeded.service
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: this line is duplicated below so it's all fine

Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyga zyga merged commit d51ac0c into snapcore:master Aug 31, 2018
@Conan-Kudo Conan-Kudo deleted the fedora-dist-git-2.35 branch August 31, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants