spread-shellcheck: fix interleaved error messages, tweaks #5951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When shellcheck identifies erorrs in many files, the error log will be interleaved as the logging is happening from inside of the helper ran by a thread pool executor. Tweak the code so that the helpers return the error instead of doing the logging directly. Minor logging cleanup. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
chipaca
approved these changes
Oct 9, 2018
spread-shellcheck
Outdated
|
|
||
| with ThreadPoolExecutor(max_workers=max_workers) as executor: | ||
| for serr in executor.map(check1path, locations): | ||
| if not isinstance(serr, ShellcheckError): |
There was a problem hiding this comment.
wouldn't this work better with if serr is None?
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shellcheck identifies erorrs in many files, the error log will be
interleaved as the logging is happening from inside of the helper ran by a
thread pool executor. Tweak the code so that the helpers return the error
instead of doing the logging directly.
Minor logging cleanup.