cmd/snap, userd, testutil: tweak DBus tests to use private session bus connection #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBus test suite must use a private connection to the session bus to avoid potential problems with other code using a shared connection. Especially, avoid using the same connecion as code under test. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Do not use the shared connection to avoid potential conflicts with other code. In particular, managing the lifetime of a shared connection is error prone as Close() must not be called for shared connections, but can safely be called for private ones. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Tweak the code for testing userd's session bus support and name registration. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
zyga
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared connections have special requirements for lifetime management. In particular methods such as
dbus.Conn.Close()must not be called on shared connections. Refactor the code to use private bus connections which do not have such limitations. This also makes the test suite code use a different connection object than the code being tested.