cmd/snap-confine,snap-update-ns: discard quirks #6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs more tweaks. I suspect I removed too many apparmor permissions. |
Recent discussion about LXD has resurrected the topic of quirks. Quirks were created in response to a bug where a snap in devmode being unable to interact with with LXD running as a classic package. At the time it was a big deal so we implemented the quirk and everything was fine. Time passed and LXD moved away from storing the socket in that place. It also moved away from shipping as a classic package as well. Since we never allowed access to /var/lib/lxd via any interfaces and it is unlikely anyone still relies on this quirk I think it should be dropped now. Removing should speed up execution of all snaps by a small amount, since we don't need to construct a writable mimic in /var/lib anymore. We also shrink snap-confine by removing a good chunk of C code. https://bugs.launchpad.net/snap-confine/+bug/1613845 Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
zyga
force-pushed
the
feature/no-more-quirks
branch
from
0e4427e
to
4286f6f
Compare
Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
zyga
force-pushed
the
feature/no-more-quirks
branch
from
4286f6f
to
7875d71
Compare
jdstrand
approved these changes
Nov 14, 2018
mvo5
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent discussion about LXD has resurrected the topic of quirks. Quirks
were created in response to a bug where a snap in devmode being unable
to interact with with LXD running as a classic package. At the time it
was a big deal so we implemented the quirk and everything was fine.
Time passed and LXD moved away from storing the socket in that place. It
also moved away from shipping as a classic package as well. Since we
never allowed access to /var/lib/lxd via any interfaces and it is
unlikely anyone still relies on this quirk I think it should be dropped
now.
Removing should speed up execution of all snaps by a small amount, since
we don't need to construct a writable mimic in /var/lib anymore. We
also shrink snap-confine by removing a good chunk of C code.
https://bugs.launchpad.net/snap-confine/+bug/1613845
Signed-off-by: Zygmunt Krynicki me@zygoon.pl