spread: drop Fedora 27, add Fedora 29 #6193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
|
I think this is blocked on the repackaging design bug in our test suite. We cannot land this without addressing that. Form thread is https://forum.snapcraft.io/t/issue-with-repackaged-core-and-testing/8394 Also discussed this with @mvo5 and we have some more context, would love to have a call to discuss how to move forward. |
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
zyga
approved these changes
Dec 4, 2018
|
The remark is no longer a blocker because F29 is manual and thus won't break anything. We still need to change the way we rebuild and repackage snapd snap for tests as it is fundamentally broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Fedora 29, while at it drop Fedora 27.