Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: discard mount namespaces in reset.sh #6203

Merged
merged 2 commits into from Nov 23, 2018

Conversation

zyga
Copy link
Collaborator

@zyga zyga commented Nov 23, 2018

Some tests install snaps and then wipe the state manually. Normally we
remove all snaps in the cleanup section but without state we cannot do
that.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

Some tests install snaps and then wipe the state manually. Normally we
remove all snaps in the cleanup section but without state we cannot do
that.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
@zyga zyga added the Simple 😃 A small PR which can be reviewed quickly label Nov 23, 2018
Copy link
Contributor

@chipaca chipaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok :-)

Copy link
Contributor

@stolowski stolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, with one suggestion

tests/lib/reset.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks zyga!

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
@zyga zyga merged commit a11ed34 into snapcore:master Nov 23, 2018
@zyga zyga deleted the fix/leftovers-v2 branch November 23, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
4 participants