interfaces: add network-manager-observe interface (2.37) #6457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetworkManager offers a very large API that is wholly exposed via the network-manager interface. Some applications (eg, QtNetworkBearer) use NetworkManager to check for connectivity and therefore do not require access to the entire API. Implement the network-manager-observe interface that exposes the Get* and List methods required for verifying connectivity. Since this grants access to things like MAC addresses and previous networks, treat this like network-observe and require manual connection. This interface does not grant access to NetworkManager's GetSecrets() API. On classic distro, this interface lets the application communicate with the system NetworkManager using the specified APIs. On all snaps systems, a providing snap interested in exposing this smaller API is expected to slot this interface in addition to the fuller network-manager interface, which contains all the permanent slot policy needed to run as NetworkManager (ie, this interface is currently not standalone as there are no known applications that only implement this reduced NM API). References: https://forum.snapcraft.io/t/qt-network-bearer-networkmanager-access-extend-network-observe/8399
|
@jdstrand I understand that is low risk in some ways, but adding a full interface to a dot release seems strange to me from a tracking/testing POV |
|
it's feels a bit late for 2.37 for this one (also considering the main PR has questions/comments) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6456 for 2.37.