cmd/snap-confine: call sc_should_use_normal_mode once #6573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically snap-confine used two modes of operation. Initially on core systems snap-confine would unshare the mount namespace and preform some alterations but would otherwise run with the contents of the initial mount namesapce. On classic systems snap-confine would pivot into the base snap (core) and perform some more alterations. With the introduction of multiple boot bases, per-snap bases some of that logic seems rusty. To make it less confusing what is going on reduce the number of places that determine if legacy (sans-pivot) or normal mode (with pivot) to exactly one. There is more cleanup that can be done but it will require making the invocation structure something we can pass around to more functions. This will be attempted in subsequent patches. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
This allows us to almost start passing sc_invocation instead of a plethora of arguments to various functions inside ns-support and mount-support modules. This also makes it a tiny bit problematic because is_normal_mode is a boolean that is only set inside the non-classic code path. This is correct for now but should be carefully changed later. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
mvo5
approved these changes
Mar 8, 2019
pedronis
approved these changes
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically snap-confine used two modes of operation. Initially on core
systems snap-confine would unshare the mount namespace and preform some
alterations but would otherwise run with the contents of the initial
mount namesapce. On classic systems snap-confine would pivot into the
base snap (core) and perform some more alterations.
With the introduction of multiple boot bases, per-snap bases some of
that logic seems rusty. To make it less confusing what is going on
reduce the number of places that determine if legacy (sans-pivot) or
normal mode (with pivot) to exactly one.
There is more cleanup that can be done but it will require making the
invocation structure something we can pass around to more functions.
This will be attempted in subsequent patches.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com