daemon, interfaces, travis: workaround build ID with Go 1.9, use 1.9 for travis tests #7063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is assumed that the test binary has a build ID, either added by Go toolchain (happens by default with Go 1.10+) or by gcc (only when built with CGO). Since osutil package no longer requires CGO, the latter case does take place. When running with Go 1.9, the tests assuming build ID presence fail because the Go toolchain never added one. Instead of working around the toolchain, add mocking where needed. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
It is assumed that the test binary has a build ID, either added by Go toolchain (happens by default with Go 1.10+) or by gcc (only when built with CGO). Since osutil package no longer requires CGO, the latter case does take place. When running with Go 1.9, the tests assuming build ID presence fail because the Go toolchain never added one. Instead of working around the toolchain, add mocking where needed. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Not _all_ distros are on 1.10 (looking at you, amz2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrecting #7060
It is assumed that the test binary has a build ID, either added by Go
toolchain (happens by default with Go 1.10+) or by gcc (only when built with
CGO). Since osutil package no longer requires CGO, the latter case does take
place.
When running with Go 1.9, the tests assuming build ID presence fail because the
Go toolchain never added one. Instead of working around the toolchain, add
mocking where needed.