gadget: support for writing symlinks #7137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
The pc and pi snaps do not use symlinks for its data. Since symlink handling during update would be awkward enough, error out rather than silently fail. We will add support when such need arises. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
zyga
reviewed
Jul 22, 2019
zyga
reviewed
Jul 22, 2019
zyga
reviewed
Jul 22, 2019
gadget/mountedfilesystem.go
Outdated
| @@ -520,6 +541,11 @@ func (f *MountedFilesystemUpdater) checkpointPrefix(dstRoot, target string, back | |||
| for prefix := filepath.Dir(target); prefix != "." && prefix != "/"; prefix = filepath.Dir(prefix) { | |||
| prefixDst, prefixBackupBase := f.entryDestPaths(dstRoot, "", prefix, backupDir) | |||
|
|
|||
| // TODO: enable support for symlnks when needed | |||
There was a problem hiding this comment.
Suggested change
| // TODO: enable support for symlnks when needed | |
| // TODO: enable support for symlinks when needed |
zyga
reviewed
Jul 22, 2019
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for writing symlinks in mounted filesystem writer. Since mounted filesystem writer is used for 'populating the staging directory while preparing a structure image in
snap-image, this enables us to correctly preserve optimizations made bysnap prepare-image.At the same time, symlinks are awkward during update, thus updated will loudly complain about symlinks.