tests: add --quiet switch to retry-tool #7397
Conversation
Pawel made a case for using retry-tool in situations where we know and anticipate the first few attempts of a command to fail, e.g. while waiting for some asynchronous operation to finish. In that case the default output doesn't help much, as we routinely fail on the road to eventual success. For this use case, add the --quiet switch, to silence all output from the tool itself. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
| time.sleep(wait) | ||
| else: | ||
| if n > 1: | ||
| if verbose and n > 1: |
There was a problem hiding this comment.
We expected the command to succeed in n attempts, so reaching here is unexpected. Wonder if we should print the message anyway. Makes the switch named --quiet a bit akward, so maybe --no-log then?
There was a problem hiding this comment.
I was thinking about it as well, oh oh :) Such a hard choice.
So here's my proposal instead. I was thinking about this earlier but decided not to do it because YAGNI but this shows it may have been useful:
The -n switch can now be both a number and a range n-m. When it is a range it indicates that we expect the first n attempts to fail and those automatically become quiet. After those the remaining up-to-m attempts log as usual.
There was a problem hiding this comment.
Sounds like a followup material.
There was a problem hiding this comment.
Yeah, I'm happy to iterate on this some more. We can always respect --quiet even if we have the range syntax implemented.
| time.sleep(wait) | ||
| else: | ||
| if n > 1: | ||
| if verbose and n > 1: |
There was a problem hiding this comment.
Sounds like a followup material.
Pawel made a case for using retry-tool in situations where we know and
anticipate the first few attempts of a command to fail, e.g. while
waiting for some asynchronous operation to finish. In that case the
default output doesn't help much, as we routinely fail on the road to
eventual success.
For this use case, add the --quiet switch, to silence all output from
the tool itself.
Signed-off-by: Zygmunt Krynicki me@zygoon.pl