tests: extend mount-ns test to handle mimics #7442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/main/mount-ns/google.ubuntu-16.04-64/PER-SNAP-18.expected.txt
Outdated
Show resolved
Hide resolved
zyga
force-pushed
the
feature/mimic-namespace-test
branch
from
a5a8bf1
to
99fbe03
Compare
|
I've rebased this now and it's crystal clear that the mimic code is giving drastically different result between core16 and core18. |
|
@anonymouse64 I will investigate the discrepancy and knowing the outcome continue either by proposing to merge this as-is or change the test to "hide" it. It is possible that this is not an actual bug and rather a peculiar arrangement of the core18 filesystem at play. |
bboozzoo
reviewed
Sep 12, 2019
The mount namespace test is very useful for exploring the layout of the mount namespace used by snapd under various circumstances. The test already covered several key combinations of the mount namespace: Ubuntu 16.04 and 18.04 both as classic and core hosts also as base snaps. The test explored the vanilla behavior of the mount namespace, as constructed by snap-confine. This patch extends that test to cover the properties of writable mimic, as created by snap-update-ns. This test is meant as a prerequisite for the upcoming change to propagation in mount namespaces. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
zyga
force-pushed
the
feature/mimic-namespace-test
branch
from
99fbe03
to
1194565
Compare
anonymouse64
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mount namespace test is very useful for exploring the layout of the
mount namespace used by snapd under various circumstances. The test
already covered several key combinations of the mount namespace: Ubuntu
16.04 and 18.04 both as classic and core hosts also as base snaps. The
test explored the vanilla behavior of the mount namespace, as
constructed by snap-confine.
This patch extends that test to cover the properties of writable mimic,
as created by snap-update-ns. This test is meant as a prerequisite for
the upcoming change to propagation in mount namespaces.
NOTE: This patch is also showing the effect of bug https://bugs.launchpad.net/snapd/+bug/1843423 - namely that /usr/share holds the mimic tmpfs, rather than what one might expect, /usr/share/X11.
Signed-off-by: Zygmunt Krynicki me@zygoon.pl