Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/snap-bootstrap: stub out snap.SanitizePlugsSlots for real #7838

Merged
merged 1 commit into from Dec 4, 2019
Merged

cmd/snap-bootstrap: stub out snap.SanitizePlugsSlots for real #7838

merged 1 commit into from Dec 4, 2019

Conversation

chipaca
Copy link
Contributor

@chipaca chipaca commented Dec 4, 2019

we were stubbing it out in the tests but not in the actual code...

@chipaca
cmd/snap-bootstrap: stub out snap.SanitizePlugsSlots for real
159e049 
we were stubbing it out in the tests but not in the actual code...
@chipaca chipaca added Simple 😃 A small PR which can be reviewed quickly Bug labels Dec 4, 2019
@chipaca chipaca requested a review from mvo5 December 4, 2019 12:53
pedronis
pedronis approved these changes Dec 4, 2019
View reviewed changes
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

mvo5
mvo5 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mvo5 mvo5 added the ⚠ Critical High-priority stuff (e.g. to fix master) label Dec 4, 2019
@chipaca chipaca merged commit 811d5d5 into snapcore:master Dec 4, 2019
@chipaca chipaca deleted the stub-out-sanitize-plugs-slots branch December 5, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvo5 mvo5 mvo5 approved these changes

@pedronis pedronis pedronis approved these changes

Assignees
No one assigned
Labels
⚠ Critical High-priority stuff (e.g. to fix master) Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Milestone
No milestone
3 participants
@chipaca @mvo5 @pedronis