run-checks: complain about MATCH -v #7930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MATCH -v with multiline input can produce incorrect results and can be replaced with more correct alternatives (eg. "not MATCH" , or "! MATCH"). Complain when MATCH -v is found in the spread test code. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Use of MATCH -v is often incorrect since it returns 0 when there are lines not matching the pattern in the input. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/run-chceks-match-v
branch
from
e64fea5
to
a17652f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MATCH -v with multiline input can produce incorrect results and can be replaced
with more correct alternatives (eg.
not MATCH, or! MATCH). Complain whenMATCH -v is found in the spread test code.