snap-bootstrap: mount the correct snapd snap to /run/mnt/snapd #7957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that the snapd snap for the given recovery system is mounted to /run/mnt/snapd. With this in place we can modify the script in `core20:/usr/lib/core20/run-snapd-from-snap` to use this path instead of mounting a "random" snapd snap to bootstrap.
mvo5
added a commit
to mvo5/core20
that referenced
this pull request
Jan 6, 2020
With snapcore/snapd#7957 snap-boostrap will mount the "correct" snapd snap to /run/mnt/snapd. With that in place we can simplify the run-snapd-from-snap script and also avoid potentially mounting a random snapd snap when there are multiple recovery systems. This commit keeps the old way of doing things for compatiblity but once the snapd PR is merged we can remove the compat code.
mvo5
added a commit
to mvo5/core20
that referenced
this pull request
Jan 6, 2020
With snapcore/snapd#7957 snap-boostrap will mount the "correct" snapd snap to /run/mnt/snapd. With that in place we can simplify the run-snapd-from-snap script and also avoid potentially mounting a random snapd snap when there are multiple recovery systems. This commit keeps the old way of doing things for compatiblity but once the snapd PR is merged we can remove the compat code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that the snapd snap for the given recovery system
is mounted to /run/mnt/snapd. With this in place we can modify
the script in
core20:/usr/lib/core20/run-snapd-from-snaptouse this path instead of mounting a "random" snapd snap to
bootstrap.
Based on #7953
Relevant commit: 2e00af0
Matching core20 change: snapcore/core20#18