boot: split MakeBootable implementations into their own file #7973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Not adding one to NameAndRevision because it will be ripped out in short order. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
mvo5
approved these changes
Jan 9, 2020
| @@ -150,7 +144,7 @@ type bootState interface { | |||
| // revisions retrieves the revisions of the current snap and | |||
| // the try snap (only the latter might not be set), and | |||
| // whether the snap is in "trying" state. | |||
| revisions() (snap, try_snap *NameAndRevision, trying bool, err error) | |||
There was a problem hiding this comment.
Hm, I wonder why the static checks have not warned about those. In any case, thanks for the fix!
There was a problem hiding this comment.
well tbh the thing that is complaining for me is go-lint, which is more strict than go vet, so run-checks won't complain about it. just a little nit pick thing that I don't think we need to block PR's on, so we don't need to add anything to run-checks
pedronis
reviewed
Jan 9, 2020
pedronis
approved these changes
Jan 9, 2020
pedronis
changed the title
* Add "." to end of doc-comments for consistency * Move MakeBootable to right after BootableSet for simplicity Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
force-pushed
the
tweak/split-boot-go-make-bootable
branch
from
5f1e418
to
beaf0a8
Compare
|
whoops I had a typo in one of my commit messages and thought I had fixed it before pushing up first time, evidently not and accidentally force-pushed |
|
The uc20 regression test suite failed because the reboot request timed out: As such, I restarted it since there wasn't more details in the logs |
pedronis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some drive-by tweaks to add doc-comments and remove underscores from some variable names.