data/selinux, test/main/selinux-clean: update the test to cover more scenarios #7978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After investigating a number of SELinux policy bug reports in RHBZ, it's clear that the test does not cover most of the typical usage patterns. Extend the test to cover more scenarios. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Pole holes for: - automatic copy of snapd data done by snapd, where cp is invoked by snapd (as system_u) but acts on user objects (unconfined_u) - layout updates triggered by snapd - mounting on top of bin_t for pulling snapd libexecdir from the host into the snap - acting on snappy_tmp_t, with auto transition from tmp_t and user_tmp_t Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1778180 (and dupes) Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1731498 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1729017 Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Conan-Kudo
approved these changes
Jan 10, 2020
stolowski
approved these changes
Jan 10, 2020
data/selinux/snappy.te
Outdated
| admin_pattern(snappy_mount_t, snappy_tmp_t) | ||
| # FIXME: investigate further why transition from user_tmp_t to snappy_tmp_t may | ||
| # not happen | ||
| # should we still end up with user_tmp_t allow acting on it too allow |
There was a problem hiding this comment.
s/too/to/?
Is this refering a known RHBZ bug? If so, could you link it?
| su test -c "test-snapd-desktop.cmd sh -c 'echo hello world'" | ||
| su test -c "test-snapd-desktop.cmd sh -c 'mkdir \$HOME/foo && echo foo > \$HOME/foo/bar'" | ||
| ausearch -i --checkpoint stamp --start checkpoint -m AVC 2>&1 | MATCH 'no matches' | ||
| # another revision triggers copy of snap data |
There was a problem hiding this comment.
Thanks for updating the test!
mvo5
approved these changes
Jan 10, 2020
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigating a number of SELinux policy bug reports in RHBZ, it's clear
that the test does not cover most of the typical usage patterns. Extend the test
to cover more scenarios.
Policy update is WIP and will be pushed to the PR
cc @Conan-Kudo