cmd/snap-update-ns: ignore EROFS from rmdir/unlink #8285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surprisingly, unlink/remove can return EROFS when the file being removed is a bind mount from writable filesystem onto a read-only filesystem. This was not handled by snap-update-ns logic before. The case was reported by the MAAS team, many thanks for their reliable reproduction instructions. Fixes: https://bugs.launchpad.net/snapd/+bug/1867752 Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
bboozzoo
reviewed
Mar 17, 2020
zyga
commented
Mar 17, 2020
mvo5
approved these changes
Mar 18, 2020
bboozzoo
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly, unlink/remove can return EROFS when the file being removed
is a bind mount from writable filesystem onto a read-only filesystem.
This was not handled by snap-update-ns logic before.
The case was reported by the MAAS team, many thanks for their reliable
reproduction instructions.
Fixes: https://bugs.launchpad.net/snapd/+bug/1867752
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com