Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis.yml: disable unit tests on travis #8432

Merged
merged 1 commit into from Apr 6, 2020

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Apr 6, 2020

We already run our unit tests as a github action and also run them
as part of the spread "tests/unit/go/" testing. So this commit
removes them from running on travis.

We already run our unit tests as a github action and also run them
as part of the spread "tests/unit/go/" testing. So this commit
removes them from running on travis.
@mvo5 mvo5 added the Simple 😃 A small PR which can be reviewed quickly label Apr 6, 2020
Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a "go master/xenial static and unit test suite" below, does that also need to go?

@mvo5
Copy link
Contributor Author

mvo5 commented Apr 6, 2020

@zyga I kept it for now because it's nice to run out tests against go master as an early indication if anything breaks. We could move this to GH actions too via the "go" snap and the latest channel (?).

@zyga
Copy link
Collaborator

zyga commented Apr 6, 2020

Thanks, I missed the fact that "master" is "go master" not "snapd master".

@zyga
Copy link
Collaborator

zyga commented Apr 6, 2020

@mvo5 this failed on ...

----------------------------------------------------------------------

FAIL: cmd_sign_build_test.go:73: SnapSignBuildSuite.TestSignBuildWorks

cmd_sign_build_test.go:91:

    c.Assert(err, IsNil)

... value *errors.errorString = &errors.errorString{s:"cannot sign assertion: cannot sign assertion: bad GPG produced signature: it does not verify: openpgp: invalid signature: RSA verification failure"} ("cannot sign assertion: cannot sign assertion: bad GPG produced signature: it does not verify: openpgp: invalid signature: RSA verification failure")

@mvo5 mvo5 merged commit fd6bd84 into snapcore:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
3 participants