github: partition the github action workflows #8489
Conversation
mvo5
force-pushed
the
split-actions
branch
6 times, most recently
from
77bb57e
to
e13db81
Compare
mvo5
added
⛔ Blocked
Skip spread
mvo5
force-pushed
the
split-actions
branch
2 times, most recently
from
211895d
to
d313dd1
Compare
This commit partitions the spread systems into multiple actions that are each unit tested with a different go version. This allows independent restarts and also earlier failures if a specific go version does break the tests. The common code in unit-tests-* should be shared somehow, maybe via a custom action. But that can be done in a followup.
| on: | ||
| pull_request: | ||
| branches: [ "master", "release/**" ] | ||
| jobs: | ||
| unit-tests: | ||
| unit-tests-1_10: |
There was a problem hiding this comment.
Each workflow has private identifiers, you can just keep this at unit-tests without ill effects.
There was a problem hiding this comment.
That's what I did initially but iirc it looked not super nice in the web UI, it was a bit confusing what was running where etc.
| @@ -30,15 +30,21 @@ jobs: | |||
| with: | |||
| path: /var/cache/apt | |||
| key: var-cache-apt-{{ hashFiles('**/debian/control') }} | |||
| - name: Run "apt update" | |||
There was a problem hiding this comment.
Why is this moved out to a separate step? On a cache hit you avoid this entire section.
There was a problem hiding this comment.
Unfortunately the archive/ppa changes all the time so "apt install foo" will not work after a couple of days because the cache has v1.22 but the archive has moved on to 1.23 but the cache was not updated because nothing in debian/control has changed.
There was a problem hiding this comment.
Actually I think this is needed because of a hash key collision somehow
| # golang 1.10 is used on 14.04/16.04/18.04 | ||
| - name: Install the go snap | ||
| run: | | ||
| sudo snap install --classic --channel=1.10 go |
There was a problem hiding this comment.
This is excellent :) Feels like we are really doing something right :)
|
Does this need some repo level switches to be changed? There is a bunch of |
|
@bboozzoo Yes, it needs an update to the required actions, I will do that once this is ready to land. |
| @@ -1,18 +1,18 @@ | |||
| name: Tests | |||
| name: Tests go1.10 | |||
There was a problem hiding this comment.
Maybe we should name the workflows go1.xx unit and spread[-unstable] native?
This commit partitions the spread systems into multiple actions
that are each unit tested with a different go version. This
allows independent restarts.