New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data: fix shellcheck warnings in snapd.sh.in #8520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Nice catch
The CLA check seems to be broken:
|
Indeed. I signed the CLA after the creation of pull request, could be related. |
I think it is something else, the cla-check looks for two "parent ..." entries reported by |
Perhaps merging master to this branch and pushing will fix it. |
Yes, I didn't create another branch from master on the fork, I simply committed on the forked master and then created a pull request. So what should I do? Merge the snapcore:master into my forked master and try to push again? |
@jelovac Please try this, if that does not work we will find another way to fix it :) |
Yay, it worked :) |
yeah :) |
@mvo5 we can merge this now, the test failures are unrelated. |
@jelovac can you merge master once more and push. Or please enable edits from maintainers, so that I can push the merge myself. |
@bboozzoo merged. Option "Allow edits by maintainers" was already enabled. |
While troubleshooting why snapd is not added to path in Linux Mint LMDE 4 I noticed some shellcheck warnings.
This tiny fix resolves them.
Update
Signed the CLA and added the git email address to the launchpad account.