data/completion: add snap command completion for zsh
#8580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add completion function for snap command for zsh. Most of heavy lifting is done by go-flags and our completion helpers, this just glues everything together. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Conan-Kudo
approved these changes
Apr 29, 2020
bboozzoo
force-pushed
the
bboozzoo/zsh-completion
branch
from
f02c4b5
to
060556f
Compare
zyga
requested changes
Apr 30, 2020
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/zsh-completion
branch
from
060556f
to
6a35b18
Compare
zyga
approved these changes
Apr 30, 2020
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
…nto bboozzoo/zsh-completion
This was referenced May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add completion function for snap command for zsh. Most of heavy lifting is done by go-flags and our completion helpers, this just glues everything together.
Even though I'm a zsh user, I'm hardly an expert. However, the completion seems to work now.
I did not add anything to
Suggestson Ubuntu on Debian. Should it be extended?I also wasn't sure about pulling in dependency on
zshpackage in Fedora and openSUSE. Seems like/usr/share/zsh/site-functionshas shared ownership, so tried to do the same in the spec.cc @Conan-Kudo