tests: add session-tool --has-systemd-and-dbus #8586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonymouse64
approved these changes
Apr 30, 2020
| # and systemd-shim is really responding to "systemd" requests. | ||
| test -n "$(command -v busctl)" || ( echo "no busctl"; exit 1 ) | ||
| if [ "$user" = "root" ]; then | ||
| # /lib /usr/lib (if present) dbus-broker.service variant |
There was a problem hiding this comment.
spacing seems off on this comment?
There was a problem hiding this comment.
The file uses tabs. not spaces. I could reformat everything but unless I do so this line will look off in various previews with different tab size.
There was a problem hiding this comment.
could you do it in a follow-up with just the white space change so that I can turn off white space in the diff and approve an empty PR :-)
Instead of encoding where a specific test can pass and where it cannot based on a snapshot of the knowledge, we now can ask session-tool for an opinion. The check performed looks for systemd support and DBus socket and service, as a minimal "this looks like a session" baseline. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
zyga
force-pushed
the
feature/session-tool-query
branch
from
93c699e
to
faf920e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of encoding where a specific test can pass and where it cannot
based on a snapshot of the knowledge, we now can ask session-tool for an
opinion.
The check performed looks for systemd support and dbus socket and
service, as a minimal "this looks like a session" baseline.
Signed-off-by: Zygmunt Krynicki me@zygoon.pl