Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: session-tool allows preparing/restoring for many users #8587

Merged
merged 1 commit into from May 4, 2020

Conversation

zyga
Copy link
Collaborator

@zyga zyga commented Apr 30, 2020

Some tests need to interact with more than one user. Due to how the
prepare and restore logic runs, we cannot call --prepare and --restore
more than once. To support such use cases the -u switch, for --prepare
and --restore alone, now supports multiple users using -u user1,user2,...
syntax.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the improvements

Copy link
Contributor

@stolowski stolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Some tests need to interact with more than one user. Due to how the
prepare and restore logic runs, we cannot call --prepare and --restore
more than once. To support such use cases the -u switch, for --prepare
and --restore alone, now supports multiple users using -u user1,user2,...
syntax.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
@zyga zyga force-pushed the feature/session-tool-many-users branch from 23e0f79 to c525250 Compare May 4, 2020 11:28
@mvo5 mvo5 merged commit c525250 into snapcore:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants