sysconfig: use new _writable_defaults dir to create cloud config #8612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
added a commit
to mvo5/core20
that referenced
this pull request
May 7, 2020
This commit move /etc/cloud from a synced dir to a persistent dir. Synced dirs have strange semantics, e.g. the user cannot remove a file that is also present in the core20 snap in the dir without it coming back on the next reboot. Hence we want to avoid any synced dirs. This requires the following prereqs: snapcore#46 snapcore/snapd#8612 first.
This commit creates the cloud configuration during install using the new _writable_defaults mechanism from: snapcore/core20#46 This allows us to remove the "synced" setting from the writable-path for the /etc/cloud dir.
mvo5
force-pushed
the
use-writable-defaults
branch
from
48954c1
to
205ba81
Compare
|
This should work now |
stolowski
approved these changes
May 12, 2020
| func ubuntuDataCloudDir(rootdir string) string { | ||
| return filepath.Join(rootdir, writableDefaultsDir, "etc/cloud/") | ||
| } | ||
|
|
There was a problem hiding this comment.
I've added a more generic helper in #8533 per Samuele's comment under my PR, we can tweak this later depending on which PR lands first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates the cloud configuration during install using
the new _writable_defaults mechanism from:
snapcore/core20#46
This allows us to remove the "synced" setting from the writable-path
for the /etc/cloud dir.
Marked blocked until the new initramfs with the _writable_defaults changes
is available.
Note that the updated spread test should fail as long as the initrd does not
support _writable_defaults so this should only become green when it's actually
ready.